Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567713 --- Comment #1 from Dan Horák <dan@xxxxxxxx> 2010-02-25 05:30:01 EST --- formal review is here, see the notes explaining OK* and BAD statuses below: OK source files match upstream: dfc82202231143b9aabc81bd735c6f8a559b5109 empy-latest.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK license field matches the actual license. OK license is open source-compatible (GPLv3+). License text included in package. OK latest version is being packaged. BAD BuildRequires are proper. N/A compiler flags are appropriate. OK %clean is present. OK package builds in mock (Rawhide/x86_64). N/A debuginfo package looks complete. BAD rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. - python-devel as BR: is usually not needed when building pure python modules without C code and the set of BRs should as small as possible (https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRequires) - rpmlint complains python-empy.noarch: E: wrong-script-interpreter /usr/lib/python2.6/site-packages/em.py /usr/local/bin/python python-empy.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/em.py 0644 /usr/local/bin/python => remove the whole shebang line for example with "sed -i -e '1d' em.py" in %prep section -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review