Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=554234 Naveen Kumar <nkumar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nkumar@xxxxxxxxxx --- Comment #14 from Naveen Kumar <nkumar@xxxxxxxxxx> 2010-02-25 02:11:08 EST --- Here's an unofficial review, using the Tibbs checklist as reference from: http://fedoraproject.org/wiki/User:Tibbs/Review_Template - source files do not match upstream: sha256sum OUTPUT: 7b0a201dfbf9ea803c09f17a660aad37b0ae1b0dbe495b5385c4447df0d04d83 ibus-table-yinma-1.2.0.20100111.tar.gz (Upstream) 8794dd5b3cfbd4c31abcb993dbc918a2879e8de995db1fe2e0a8ac9652832439 ../ibus-table-yinma-1.2.0.20100111.tar.gz (Source) + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible: license text included in package. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. - package does not build in Koji for dist-f12 (despite being noarch): http://koji.fedoraproject.org/koji/taskinfo?taskID=2012743 + package builds in Koji for dist-f13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2012745 + package installs properly. * rpmlint output with warnings.(rpmlint version 0.94) rpmlint OUTPUT on ibus-table-yinma-1.2.0.20100111-2.fc12.src.rpm & ibus-table-yinma-1.2.0.20100111-2.fc14.src.rpm: ibus-table-yinma.src: I: enchant-dictionary-not-found zh_CN ibus-table-yinma.src: I: enchant-dictionary-not-found zh_HK ibus-table-yinma.src: I: enchant-dictionary-not-found zh_TW ibus-table-yinma.src: W: spelling-error %description -l en_US zh -> ssh, z, h ibus-table-yinma.src: W: tag-in-description C Summary(zh_CN): ibus-table-yinma.src: W: tag-in-description C Summary(zh_HK): ibus-table-yinma.src: W: tag-in-description C Summary(zh_TW): ibus-table-yinma.src: W: tag-in-description zh_CN Summary(zh_CN): ibus-table-yinma.src: W: tag-in-description zh_CN Summary(zh_HK): ibus-table-yinma.src: W: tag-in-description zh_CN Summary(zh_TW): ibus-table-yinma.src: W: tag-in-description zh_HK Summary(zh_CN): ibus-table-yinma.src: W: tag-in-description zh_HK Summary(zh_HK): ibus-table-yinma.src: W: tag-in-description zh_HK Summary(zh_TW): ibus-table-yinma.src: W: tag-in-description zh_TW Summary(zh_CN): ibus-table-yinma.src: W: tag-in-description zh_TW Summary(zh_HK): ibus-table-yinma.src: W: tag-in-description zh_TW Summary(zh_TW): ibus-table-yinma.src:18: W: unversioned-explicit-provides ibus-table-yong ibus-table-yinma.src:18: W: unversioned-explicit-provides ibus-table-erbi 1 packages and 0 specfiles checked; 0 errors, 15 warnings. rpmlint OUTPUT on ibus-table-yinma-1.2.0.20100111-2.fc14.noarch.rpm: ibus-table-yinma.noarch: I: enchant-dictionary-not-found zh_CN ibus-table-yinma.noarch: I: enchant-dictionary-not-found zh_HK ibus-table-yinma.noarch: I: enchant-dictionary-not-found zh_TW ibus-table-yinma.noarch: W: spelling-error %description -l en_US zh -> ssh, z, h ibus-table-yinma.noarch: W: tag-in-description C Summary(zh_CN): ibus-table-yinma.noarch: W: tag-in-description C Summary(zh_HK): ibus-table-yinma.noarch: W: tag-in-description C Summary(zh_TW): ibus-table-yinma.noarch: W: self-obsoletion ibus-table-erbi <= 1.2.0.20100111 obsoletes ibus-table-erbi ibus-table-yinma.noarch: W: self-obsoletion ibus-table-yong <= 1.2.0.20100111 obsoletes ibus-table-yong 1 packages and 0 specfiles checked; 0 errors, 6 warnings. * final provides and requires are sane: rpm -qp --provides OUTPUT on ibus-table-yinma-1.2.0.20100111-2.fc14.noarch.rpm: ibus-table-erbi ibus-table-yong ibus-table-yinma = 1.2.0.20100111-2.fc14 rpm -qp --requires OUTPUT on ibus-table-yinma-1.2.0.20100111-2.fc14.noarch.rpm : /bin/sh ibus-table >= 1.2 ibus-table >= 1.2 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 rpmlib(PayloadIsXz) <= 5.2-1 + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + scriptlets sane. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. + no headers. + no pkgconfig files. + no libtool .la droppings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review