[Bug 565616] Review Request: libeina - Data Type Library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=565616

Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #11 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> 2010-02-24 19:12:04 EST ---
I tried with:

%check
LD_LIBRARY_PATH=$( pwd )/src/lib/.libs/
LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$( pwd )/src/modules/mp/pass_through/.libs/
LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$( pwd )/src/modules/mp/chained_pool/.libs/
LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$( pwd )/src/modules/mp/fixed_bitmap/.libs/
LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$( pwd )/src/tests/.libs/
export LD_LIBRARY_PATH
make check

but still the tests fail. We should leave them out for now, but please work
with upstream on getting this fixed.
And please disable the tests in configure for now because they end up in the
debuginfo package


OK, lest check the remaining items:
OK - MUST: $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/libeina-*
libeina.src: W: spelling-error %description -l en_US Eina -> Erna, Etna, Edna
libeina.src: W: spelling-error %description -l en_US multi -> mulch, mufti
libeina.x86_64: W: spelling-error %description -l en_US Eina -> Erna, Etna,
Edna
libeina.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti
libeina-devel.x86_64: W: spelling-error Summary(en_US) Eina -> Erna, Etna, Edna
4 packages and 0 specfiles checked; 0 errors, 5 warnings.

All warnings are bogus, ignore them.

OK - MUST: Fedora approved license and meets the Licensing Guidelines: LGPLv2
OK - MUST: License field in spec file matches the actual license
OK - MUST: successfully compiles and builds into binary rpms on x86_64
OK - MUST: all build dependencies are listed in BuildRequires.
OK - MUST: Packages containing pkgconfig(.pc) files must 'Requires:
pkgconfig'.

SHOULD Items:
OK - SHOULD: builds in mock
OK - SHOULD: compiles and builds into binary rpms on all supported
architectures.
OK - SHOULD: functions as described.

Other items:
TBD - Debuginfo complete

All issues are fixed, the package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]