Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=550690 --- Comment #7 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2010-02-24 17:12:42 EST --- (In reply to comment #4) > > Group: Applications/Internet > Shared libraries like this still belong into "System Environment/Libraries". Changed > > %{_mandir}/man*/*.gz > Since manual pages are compressed on-the-fly by rpmbuild and the compression > tool may change, prefer: %{_mandir}/man*/* > > And move these manual pages into the -devel pages, since they document the > library API. done > Why duplicate the ChangeLog? Including it in just the base package is fine. Removed from devel > > #Tests deactivated because the library checks online URLs > > #%check > > #make check > > A good opportunity to make this a conditional build, so you could simply > activate the test-suite for local builds with "rpmbuild --with tests > libsurl.src.rpm": > > %bcond_with tests > %if %{with tests} > %check > make check > %endif Added, thanks > * The %description mentions "surl" without explaining that it is a separate > tool to be found in a separate package ("surl"). Description changed Here are the updated files: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/libsurl.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/libsurl-0.7.1-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review