[Bug 567872] Review Request: gtk-v4l : Video4Linux Preferences tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567872

Hans de Goede <hdegoede@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |hdegoede@xxxxxxxxxx
               Flag|                            |fedora-review?

--- Comment #1 from Hans de Goede <hdegoede@xxxxxxxxxx> 2010-02-24 08:29:07 EST ---
I've done a full review and I've found several MUST FIX issues:
-Typo in Summary: Prefernces should be Preferences
-Drop these 2 explicit library dependencies:
 Requires: gtk2 >= 2.18
 Requires: libv4l >= 0.6
-Since your desktop file does not include a MimeType key there is no reason
 to call update-desktop-database

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]