Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557917 --- Comment #4 from Matthias Clasen <mclasen@xxxxxxxxxx> 2010-02-23 21:26:05 EST --- Some preliminary comments about the spec: # sitelib for noarch packages, sitearch for others (remove the unneeded one) Since you already removed the unneeded one, the comment should probably go Summary: GUI to browse and search your Zeitgeist activities I really hate the term 'GUI'. Can we go with 'Tool' or something like that ? Group: Development/Languages Not important at all, but the group seems wrong Source1: %{name}.desktop This should really go upstream, since it needs translations BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) Not a big deal, but not really needed anymore nowadays, rpmbuild can figure it out on its own. %{_datadir}/icons/hicolor/*/* Since you are installing icons, you need to do the icon cache dance in %post, %postun, %posttrans, etc... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review