Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=540761 --- Comment #27 from Matthias Clasen <mclasen@xxxxxxxxxx> 2010-02-23 20:42:37 EST --- package name: ok spec file name: ok packaging guidelines: there is an instance of // in the file list somewhere. for the rest, see the individual points below license: ok license field: ok license file: ok spec file language: ok readable: ok upstream source: the source url seems wrong, http://launchpad.net/deja-dup/14/13.4/+download/deja-dup-13.4.tar.bz2 is the correct url for 13.4. The tarball is identical to the upstream one. The latest version is 13.91. buildable: yes, see above ExcludeArch: ok BuildRequires: scrollkeeper is missing, see above locale handling: ok, but see above about --with-man and you might also want to look into using --with-gnome to get language tags for omf and help files ldconfig: ok system libraries: ok relocatable: no, ok directory ownership: problematic directories: /etc/gconf/schemas (owned by GConf2) /usr/lib/nautilus/extensions-2.0 (owned by nautilus) /usr/share/gnome/help (owned by yelp) /usr/share/icons/Humanity (owned by nothing ?) Library deps are covering gconf and nautilus, but you should probably add a dep for yelp, and drop the Humanity icon, since we don't have the Humanity icon theme in Fedora anyway duplicate files: ok file permissions: ok %clean: ok macro use: ok content: permissible large docs: ok %doc content: ok headers: ok static libs: ok pc files: ok shared libs: ok devel deps: ok libtool archives: ok gui apps: ok %install: needs to wipe the buildroot initially utf8 filenames: ok -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review