Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=548482 --- Comment #7 from Matthias Clasen <mclasen@xxxxxxxxxx> 2010-02-23 18:29:57 EST --- package name: ok spec file name: ok packaging guidelines: ok, could maybe loose the BuildRoot (since rpmbuild handles that itself nowadays) license: ok license field: seems wrong, COPYING is GPLv3, but you say LGPLv3+ license file: ok spec file language: ok spec file readable: ok upstream sources: ok buildable: ok ExcludeArch: ok BuildRequires: ok locale handling: ok ldconfig: ok system libraries: ok relocatable: no, ok directory ownership: need to add a totem dep for /usr/lib/totem/plugins duplicate files: ok file permissions: see above %clean: ok macro use: ok content: permissible large docs: none, ok %doc content: ok headers: ok static libs: ok pc files: ok shared libs: ok devel deps: ok libtool archives: ok gui apps: ok directory ownership: ok %install: ok utf8 filenames: ok -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review