Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=553281 --- Comment #14 from James Findley <sixy@xxxxxxx> 2010-02-23 12:32:24 EST --- Thanks for the review! I've changed the way the sources work some, in the hope of getting it to be a bit cleaner. ### Short background ### Until very recently this app used a unix domain socket, to allow stats reporting in daemon mode (an essential part of daemon mode). This is now a deprecated feature in the latest svn revisions, and is scheduled to be replaced by a better method, namely a netlink multicast group. However this is not yet implemented, and so temporarily the latest upstream misses an essential part of daemon mode. As we are building an unreleased svn version, to fix (many) issues with the latest stable, upstream aren't interested in keeping the unix domain socket around until the new method is functional. So there are basically 3 options: 1) continue to ship the buggy 0.5.4 code 2) ship the latest upstream, and put up with daemon mode being not terribly useful 3) ship this svn revision until 0.5.5.0 is final, patching the UDS server code to make it work, and packaging the client to read statistics from an older version of the source. I am proposing to do 3 - this svn revision is (after the patch) good code and has been stable across a wide range of test environments, so makes a good stop while I wait for 0.5.5.0. So what I now do is svn export the correct revision, tar it up and use that as source 0. I also use the 0.5.3 source to provide the client for the UDS. I hope that explains the reasoning behind this spec madness, and why these patches aren't appropriate for upstream. ### Short background ### Sources are fixed. Requires/Buildrequires are also fixed. I've got rid of the check_packets.tar.gz I've stopped using the macros for rm, make and install. However, rpmlint now produces some errors. SPECS/netsniff-ng.spec: W: invalid-url Source3: http://netsniff-ng.googlecode.com/files/netsniff-ng-0.5.3.tar.gz HTTP Error 404: Not Found SPECS/netsniff-ng.spec: W: invalid-url Source0: netsniff-ng-0.5.5.0.tar.gz The first is an odd error. Possibly a bug in rpmlint (I will investigate this more fully when I have time) as a wget of that URL works fine. The second is explained by the comments above, in accordance with: http://fedoraproject.org/wiki/Packaging/SourceURL Therefore I am proposing to ignore these warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review