[Bug 567240] Review Request: libgeier-0.11 -- Need Sponsor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567240

Ralf Corsepius <rc040203@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203@xxxxxxxxxx
             Blocks|                            |177841(FE-NEEDSPONSOR)

--- Comment #1 from Ralf Corsepius <rc040203@xxxxxxxxxx> 2010-02-22 11:24:48 EST ---
This package has a lot of issues - rpmlint output with comments interspersed:

# rpmlint /var/lib/mock/fedora-12-i386/result/*rpm


libgeier.i686: W: spelling-error Summary(en_US) german -> German, germane,
merman
libgeier.i686: W: spelling-error %description -l en_US german -> German,
germane, merman

- In English, "German" is always written in captial letters.


libgeier.i686: W: no-version-in-last-changelog

- You need to add versions to %changelog entries:
.... <xxx@xxxxxxx> - 0.11-1


libgeier.i686: W: no-url-tag

- URL:-Tag is missing.


libgeier.i686: E: standard-dir-owned-by-package /usr/include

- Your package must not own /usr/include. Also, files below /usr/include do not
belong into "base"-packages, but into *-devel packages.

libgeier.i686: W: devel-file-in-non-devel-package /usr/lib/libgeier.a

- 1) Shipping static libs is strongly being frowned upon in Fedora.
Please append "--disable-static" to %configure
  2) libs belong into *-devel packages.

libgeier.i686: E: zero-length /usr/share/doc/libgeier-0.11/ChangeLog

- Shipping an empty file is pointless. Don't ship it.

libgeier.i686: E: postin-without-ldconfig /usr/lib/libgeier.so.0.0.0

- Your spec lacks %post -p /sbin/ldconfig

libgeier.i686: E: library-without-ldconfig-postun /usr/lib/libgeier.so.0.0.0

- Your spec lacks %postun -p /sbin/ldconfig

libgeier.i686: E: standard-dir-owned-by-package /usr/share/man/man1

- Package must not own /usr/share/man/man1

libgeier.i686: W: devel-file-in-non-devel-package /usr/lib/libgeier.so

- *.so's belong into *-devel packages.

libgeier.i686: E: standard-dir-owned-by-package /usr/share/man

- Same as above

libgeier.i686: W: devel-file-in-non-devel-package
/usr/lib/pkgconfig/libgeier.pc

- *.pc's belong into *-devel packages.

libgeier.i686: W: empty-%pre
libgeier.i686: W: empty-%post
libgeier.src: W: spelling-error Summary(en_US) german -> German, germane,
merman
libgeier.src: W: spelling-error %description -l en_US german -> German,
germane, merman
libgeier.src: W: no-version-in-last-changelog
libgeier.src: W: no-url-tag
libgeier.src:48: E: hardcoded-library-path in /usr/lib/debug
libgeier.src:56: E: files-attr-not-set
libgeier.src:57: E: files-attr-not-set
libgeier.src: W: no-buildroot-tag
- c.f. the Fedora Packaging Guidelines.

libgeier.src: W: invalid-url Source0: libgeier-0.11.tar.gz
- Source0: is supposed to point to a valid upstream URL.


libgeier-debuginfo.i686: W: no-version-in-last-changelog
libgeier-debuginfo.i686: W: no-url-tag
libgeier-devel.i686: W: no-dependency-on libgeier/libgeier-libs/liblibgeier
libgeier-devel.i686: W: spelling-error Summary(en_US) german -> German,
germane, merman
libgeier-devel.i686: W: no-version-in-last-changelog
libgeier-devel.i686: W: no-url-tag


libgeier-devel.i686: W: unstripped-binary-or-object
/usr/lib/debug/usr/lib/libgeier.so.0.0.0.debug
libgeier-devel.i686: E: shared-lib-without-dependency-information
/usr/lib/debug/usr/lib/libgeier.so.0.0.0.debug
libgeier-devel.i686: W: unstripped-binary-or-object
/usr/lib/debug/usr/bin/geier.debug
libgeier-devel.i686: E: statically-linked-binary
/usr/lib/debug/usr/bin/geier.debug
libgeier-devel.i686: W: no-documentation
libgeier-devel.i686: E: library-without-ldconfig-postin
/usr/lib/debug/usr/lib/libgeier.so.0.0.0.debug
libgeier-devel.i686: E: library-without-ldconfig-postun
/usr/lib/debug/usr/lib/libgeier.so.0.0.0.debug
libgeier-devel.i686: W: dangling-relative-symlink
/usr/lib/debug/.build-id/0e/bd6cc0f171a58ed0a3f875502b803779d9c468
../../../../bin/geier
libgeier-devel.i686: W: hidden-file-or-dir /usr/lib/debug/.build-id
libgeier-devel.i686: W: hidden-file-or-dir /usr/lib/debug/.build-id
libgeier-devel.i686: E: library-without-ldconfig-postin
/usr/lib/libgeier.so.0.0.0
libgeier-devel.i686: E: library-without-ldconfig-postun
/usr/lib/libgeier.so.0.0.0

- Most of these are side-effects of other packaging bugs already mentioned
before.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]