Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483859 --- Comment #8 from Guido Grazioli <guido.grazioli@xxxxxxxxx> 2010-02-22 08:50:06 EST --- This is an informal review; Ed's last post was about 12 month ago, if he is still unresponsive, im willing to take this review over NEEDSWORK - rpmlint output libg3d.x86_64: W: spelling-error %description -l en_US plugins -> plug ins, plug-ins, plugging libg3d-devel.x86_64: W: spelling-error Summary(en_US) libg -> ling, lib, glib libg3d-devel.x86_64: W: spelling-error %description -l en_US libg -> ling, lib, glib libg3d.src: W: spelling-error %description -l en_US plugins -> plug ins, plug-ins, plugging 3 packages and 1 specfiles checked; 0 errors, 4 warnings. - Please correct the "plugins" warnings, you also have a typo in %changelog (last entry in 0.0.8-2 revision is empty). The warnings about "libg" can be ignored. ADDITIONAL NOTES: - /usr/lib64/libg3d/ tree is installed along -devel package: is that correct? - after installing libg3d i got for any file i tried: $ g3d-stat bridge.dxf no handler for file 'bridge.dxf' found $ g3d-stat cube.obj no handler for file 'cube.obj' found - libg3c.magic is in -devel package too - includedir in libg3d.pc should be /usr/include/g3d - the same README file is installed both in main and devel package: yum could remove it from -devel and more TODO there ========= OK - The package must be named according to the Package Naming Guidelines. OK - The spec file name must match the base package %{name} OK - The package must meet the Packaging Guidelines OK - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc OK - The package must be licensed with a Fedora approved license and meet the Licensing Guidelines (license is LGPLv2+) NA - Every binary RPM package which stores shared library files must call ldconfig in %post and %postun OK - The package MUST successfully compile and build koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2004807 OK - The spec file must be written in American English. OK - The spec file for the package MUST be legible. OK - The sources used to build the package must match the upstream source, as provided in the spec URL. 23fbb22c24b1db225a3de8b6aaf25774 libg3d-0.0.8.tar.gz OK - The spec file MUST handle locales properly NA - package not relocatable OK - A package must own all directories that it creates OK - A Fedora package must not list a file more than once in the spec file's %files listings OK - Permissions on files must be set properly OK - Each package must have a %clean section OK - Each package must consistently use macros OK - The package must contain code, or permissable content (no content) OK - Large documentation files must go in a -doc subpackage (no large doc, gtk-doc is ~ 400kb included in -devel) OK - If a package includes something as %doc, it must not affect the runtime of the application OK - Header files must be in a -devel package NA - Static libraries must be in a -static package (no static package) OK - Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' OK - Packages must NOT contain any .la libtool archives NA - Packages containing GUI applications MUST include a .desktop file OK - No file conflicts with other packages and no general names. OK - At the beginning of %install, each package MUST run rm -rf %{buildroot} OK - All filenames in rpm packages must be valid UTF-8 OK - The package does not yet exist in Fedora. The Review Request is not a duplicate. OK - %{?dist} tag is used in release -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review