Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530747 --- Comment #2 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan@xxxxxxxxxxxxx> 2010-02-22 06:44:23 EST --- (In reply to comment #1) > I want to co-maintain this package. You are welcome! > Changes: > - Split iodine to server, client and doc packages I do not see any worth in it. For what? This is small package which does not required excessive dependencies. > - Add initscripts support > - Add logrotate support Thank you, I import it with small enhancements. > - Add optflags to CFLAGS make %{?_smp_mflags} CFLAGS="-c -pedantic %{optflags} -DLINUX" You add compile flags and even do not comment for what. It is not permitted in Fedora: https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags > - Add zlib-devel to BuildRequires Thanks. > - Remove dos2unix from BuildRequires > - Don't package README-win32.txt It have not many sense, but ok, I also do that. > - Remove useless iodine-0.5.2-prefix.patch There I disagree. Patch is useful and reported to upstream. Installation all files manual across autotools functionality can be accomplished in this easy package, but in fact is bad idea. http://hubbitus.net.ru/rpm/Fedora11/iodine/iodine.spec http://hubbitus.net.ru/rpm/Fedora11/iodine/iodine-0.5.2-2.fc11.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=2004630 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review