Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566688 Iain Arnell <iarnell@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #3 from Iain Arnell <iarnell@xxxxxxxxx> 2010-02-22 05:54:24 EST --- (In reply to comment #2) > (In reply to comment #1) > > Fails to build in mock (locally, with perl-Olson-Abbreviations installed). > > There's either a missing BR on perl(CPAN), or you can run Makefile.PL with > > PERL5_CPANPLUS_IS_RUNNING=1 to avoid CPAN entirely. > > > Great macro! But it needs to be in then environment when Makefile.PL is running, not at the end of %prep, i.e. PERL5_CPANPLUS_IS_RUNNING=1 %{__perl} Makefile.PL INSTALLDIRS=vendor With that one change, it builds in mock (locally, f14, with perl-Olson-Abbreviations installed). Final provides are sane: perl(MooseX::Types::DateTime::ButMaintained) = 0.11 perl-MooseX-Types-DateTime-ButMaintained = 0.11-2.fc14 Final requires are sane: perl(:MODULE_COMPAT_5.10.1) perl(DateTime) perl(DateTime::Locale) perl(DateTime::TimeZone) perl(Moose) >= 0.41 perl(MooseX::Types) perl(MooseX::Types) >= 0.04 perl(MooseX::Types::Moose) perl(Olson::Abbreviations) perl(namespace::clean) perl(namespace::clean) >= 0.08 perl(strict) perl(warnings) and rpmlint is silent. With the small PERL5_CPANPLUS_IS_RUNNING fix, APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review