[Bug 567107] Review Request: perl-Net-SSLGlue - Add/extend SSL support for common perl modules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567107

--- Comment #1 from Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 2010-02-21 15:48:38 EST ---
Looks good.

None of the following are blockers, but rather recommendations.

Patching Makefile.PL to skip the network tests works, but it's also sufficient
to call it as:

    echo n | %{__perl} Makefile.PL INSTALLDIRS=vendor

For ease of maintenance, I might drop the patch and go the "echo n" route.

Replacing PERL_INSTALL_ROOT with DESTDIR would seem to be a good idea, given
the recent fun along those lines :)

Think about including %{?perl_default_filter} by default, even if just pro
forma.  It won't hurt anything and might save some pain down the line.

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2003380

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
88fc9207053ede70c691fbc73cd55c20137ef789 Net-SSLGlue-0.2.tar.gz
88fc9207053ede70c691fbc73cd55c20137ef789 Net-SSLGlue-0.2.tar.gz.srpm

Final provides / requires are sane:

0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-Net-SSLGlue-0.2-1.fc14.noarch.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-Net-SSLGlue-0.2-1.fc14.noarch.rpm
perl(Net::DNSGlue::LDAP) = 0.2
perl(Net::SMTP::_SSLified)  
perl(Net::SMTP::_SSL_Socket)  
perl(Net::SSLGlue) = 0.2
perl-Net-SSLGlue = 0.2-1.fc14
perl(Net::SSLGlue::LWP) = 0.2
perl(Net::SSLGlue::SMTP)  
====> requires for perl-Net-SSLGlue-0.2-1.fc14.noarch.rpm
perl(Carp)  
perl(IO::Socket::SSL) >= 1.19
perl(LWP::UserAgent)  
perl(MIME::Base64)  
perl(:MODULE_COMPAT_5.10.1)  
perl(Net::LDAP)  
perl(Net::SMTP)  
perl(strict)  
perl(URI)  
perl(URI::Escape)  
perl(warnings)  

=====> perl-Net-SSLGlue-0.2-1.fc14.src.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-Net-SSLGlue-0.2-1.fc14.src.rpm
====> requires for perl-Net-SSLGlue-0.2-1.fc14.src.rpm
perl(ExtUtils::MakeMaker)  
perl(IO::Socket::SSL) >= 1.19

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]