[Bug 567037] Review Request: perl-String-Flogger - String munging for loggers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567037

--- Comment #1 from Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 2010-02-21 15:13:45 EST ---
Looks good.

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2002510

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
b074c65433cb2ee1c6a278c010bc51762d7283b5 String-Flogger-1.001.tar.gz
b074c65433cb2ee1c6a278c010bc51762d7283b5 String-Flogger-1.001.tar.gz.srpm

Final provides / requires are sane:

0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-String-Flogger-1.001-1.fc14.noarch.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-String-Flogger-1.001-1.fc14.noarch.rpm
perl(String::Flogger) = 1.001
perl-String-Flogger = 1.001-1.fc14
====> requires for perl-String-Flogger-1.001-1.fc14.noarch.rpm
perl(JSON) >= 2
perl(:MODULE_COMPAT_5.10.1)  
perl(Params::Util)  
perl(Scalar::Util)  
perl(strict)  
perl(Sub::Exporter)  
perl(Sub::Exporter::Util)  
perl(warnings)  

=====> perl-String-Flogger-1.001-1.fc14.src.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-String-Flogger-1.001-1.fc14.src.rpm
====> requires for perl-String-Flogger-1.001-1.fc14.src.rpm
perl(ExtUtils::MakeMaker)  
perl(JSON) >= 2
perl(Params::Util)  
perl(Sub::Exporter)  
perl(Test::More)  

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]