Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=565616 Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag| |fedora-review? --- Comment #5 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> 2010-02-21 06:14:11 EST --- Review for 5d9be61bb47fa6abecdb518e50855f76 libeina-0.9.9.063-3.fc12.src.rpm TBD - MUST: rpmlint must be run on every package. The output should be posted in the review. OK - MUST: named according to the Package Naming Guidelines (note: the package was renamed to libeina to avoid the naming conflict with the media player eina) OK - MUST: spec file name matches the base package %{name} OK - MUST: package meets the Packaging Guidelines TBD - MUST: Fedora approved license and meets the Licensing Guidelines OK - MUST: License field in spec file matches the actual license OK - MUST: license file included in %doc OK - MUST: spec is in American English OK - MUST: spec is legible OK - MUST: sources match the upstream source by MD5 1289ac1d6b1a7a578158f9ff24301f3f FIX - MUST: does not successfully compile: + find doc/man/man3 -size -100c -delete find: `doc/man/man3': No such file or directory OK - MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. TBD - MUST: all build dependencies are listed in BuildRequires. N/A - MUST: handles locales properly with %find_lang OK - MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. OK - MUST: Package does not bundle copies of system libraries. N/A - MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review. OK - MUST: owns all directories that it creates OK - MUST: no duplicate files in the %files listing OK - MUST: Permissions on files are set properly, includes %defattr(...) OK - MUST: package has a %clean section, which contains rm -rf %{buildroot}. OK - MUST: consistently uses macros OK - MUST: package contains code, or permissable content N/A - MUST: Large documentation files should go in a -doc subpackage OK - MUST: Files included as %doc do not affect the runtime of the application OK - MUST: Header files must be in a -devel package N/A - MUST: Static libraries must be in a -static package FIX - MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. OK - MUST: If a package contains library files with a suffix, then library files that end in .so must go in a -devel package. OK - MUST: devel packages must require the base package using a fully versioned dependency OK - MUST: The package does not contain any .la libtool archives. N/A - MUST: Packages containing GUI applications must include a %{name}.desktop file OK - MUST: package does not own files or directories already owned by other packages. OK - MUST: at the beginning of %install, the package runs rm -rf %{buildroot}. OK - MUST: all filenames valid UTF-8 SHOULD Items: OK - SHOULD: Source package includes license text(s) as a separate file. N/A - SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. TBD - SHOULD: builds in mock. TBD - SHOULD: compiles and builds into binary rpms on all supported architectures. TBD - SHOULD: functions as described. OK - SHOULD: Scriptlets are used, those scriptlets must be sane. N/A - SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. OK - SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg OK - SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. Other items: OK - latest stable version OK - SourceURL valid OK - Compiler flags ok TBD - Debuginfo complete Issues: - Two FIX items, see above: build error, missing "Requires: pkgconfig" of the -devel package - the licensing is unclear: eina_value.c is BSD, the rest of the sources is LGPLv2+, but COPYING is GPLv2. I guess COPYING is wrong and the package is LGPLv2+. Could you clarify this with upstream? - you should add a %check section and run the included tests - ChangeLog is missing from %doc, on the other hand README is so useless you can drop it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review