[Bug 561981] Review Request: php-phpunit-PHP-TokenStream - Wrapper around PHP's tokenizer extension

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561981

Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora@xxxxxxxxxxxxxxxxx
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |fedora@xxxxxxxxxxxxxxxxx
               Flag|                            |fedora-review+

--- Comment #1 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> 2010-02-21 02:16:39 EST ---
REVIEW

+ rpmlint
php-phpunit-PHP-TokenStream.spec: I: checking-url
http://pear.phpunit.de/get/PHP_TokenStream-0.9.1.tgz (timeout 10 seconds)
php-phpunit-PHP-TokenStream.src: I: checking
php-phpunit-PHP-TokenStream.src: W: spelling-error Summary(en_US) PHP's ->
HP's, PCP's, P HP's
php-phpunit-PHP-TokenStream.src: W: spelling-error Summary(en_US) tokenizer ->
tokenism, token, patronizer
php-phpunit-PHP-TokenStream.src: W: spelling-error %description -l en_US PHP's
-> HP's, PCP's, P HP's
php-phpunit-PHP-TokenStream.src: W: spelling-error %description -l en_US
tokenizer -> tokenism, token, patronizer
php-phpunit-PHP-TokenStream.src: I: checking-url
http://github.com/sebastianbergmann/php-token-stream (timeout 10 seconds)
php-phpunit-PHP-TokenStream.src: I: checking-url
http://pear.phpunit.de/get/PHP_TokenStream-0.9.1.tgz (timeout 10 seconds)
php-phpunit-PHP-TokenStream.noarch: I: checking
php-phpunit-PHP-TokenStream.noarch: W: spelling-error Summary(en_US) PHP's ->
HP's, PCP's, P HP's
php-phpunit-PHP-TokenStream.noarch: W: spelling-error Summary(en_US) tokenizer
-> tokenism, token, patronizer
php-phpunit-PHP-TokenStream.noarch: W: spelling-error %description -l en_US
PHP's -> HP's, PCP's, P HP's
php-phpunit-PHP-TokenStream.noarch: W: spelling-error %description -l en_US
tokenizer -> tokenism, token, patronizer
php-phpunit-PHP-TokenStream.noarch: I: checking-url
http://github.com/sebastianbergmann/php-token-stream (timeout 10 seconds)
php-phpunit-PHP-TokenStream.noarch: W: no-documentation
2 packages and 1 specfiles checked; 0 errors, 9 warnings.
+ package name ok
+ spec file name ok
+ package meet the PHP Guidelines
+ License ok : BSD
+ License is upstream
+ spec in english and legible
+ no license file in sources is provided
+ sources match the upstream sources
328c7d9e95fc9b0078b180bbb8c532d1  PHP_TokenStream-0.9.1.tgz
+ Source URL ok
+ build  on F12.x86_64
+ BuildRequires ok
php-pear >= 1:1.8.1
php-channel(pear.phpunit.de)
+ no locale
+ no .so
+ own all directories that it creates
+ no duplicate file
+ %defattr ok
+ %clean section
+ use macros consistently
+ no %define
+ contain code
+ no documentation
+ no devel
+ no pkgconfig
+ no sub-package
+ no GUI
+ don't own files or directories already owned by other packages
+ %install start with rm -rf 
+ valid UTF-8
+ build in koji
+ no test suite (Tests dir in git not provided,)
+ scriptlets ok
- Final Requires 
/usr/bin/pear  
php-channel(pear.phpunit.de)  
php-common >= 5.2.0
php-tokenizer  
+ Final Provides ok
php-pear(pear.phpunit.de/PHP_TokenStream) = 0.9.1
php-phpunit-PHP-TokenStream = 0.9.1-1.fc8
+ Koji scratch build
http://koji.fedoraproject.org/koji/taskinfo?taskID=2002482


removing the PHP's in sumnary should be fine.



***** APPROVED *****

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]