Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pyserial - Python serial port access library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191175 ------- Additional Comments From adam@xxxxxxxxxxxxx 2006-10-14 18:01 EST ------- rpmlint results: E: pyserial non-executable-script /usr/lib/python2.4/site-packages/serial/serialposix.py 0644 E: pyserial wrong-script-interpreter /usr/lib/python2.4/site-packages/serial/serialwin32.py "python" E: pyserial non-executable-script /usr/lib/python2.4/site-packages/serial/serialwin32.py 0644 E: pyserial non-executable-script /usr/lib/python2.4/site-packages/serial/__init__.py 0644 E: pyserial wrong-script-interpreter /usr/lib/python2.4/site-packages/serial/serialutil.py "python" E: pyserial non-executable-script /usr/lib/python2.4/site-packages/serial/serialutil.py 0644 E: pyserial wrong-script-interpreter /usr/lib/python2.4/site-packages/serial/serialjava.py "jython" E: pyserial non-executable-script /usr/lib/python2.4/site-packages/serial/serialjava.py 0644 These are harmless, I believe. These files are not really scripts. One more thing for the specfile: since you are building a noarch package, you don't need the %{!?python_sitearch... line. (Just python_sitelib.) Also, I don't think you should be doing export libdirname=%{_lib}. Take out these 3 lines, and you should be good. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review