Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=565916 Steve Traylen <steve.traylen@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |steve.traylen@xxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |steve.traylen@xxxxxxx Flag| |fedora-review+ --- Comment #1 from Steve Traylen <steve.traylen@xxxxxxx> 2010-02-20 06:16:47 EST --- Bonjour Remi, I note the build is a little noisy: Warning: date(): It is not safe to rely on the system's timezone settings. You are *required* to use the date.ti: mezone setting or the date_default_timezone_set() function. In case you used any of those methods and you are st: ill getting this warning, you most likely misspelled the timezone identifier. We selected 'Europe/Berlin' for 'C: ET/1.0/no DST' instead in PEAR/Registry.php on line 1012 : PHP Warning: date(): It is not safe to rely on the system's timezone settings. You are *required* to use the da: te.timezone setting or the date_default_timezone_set() function. In case you used any of those methods and you a: re still getting this warning, you most likely misspelled the timezone identifier. We selected 'Europe/Berlin' f: or 'CET/1.0/no DST' instead in /usr/share/pear/PEAR/Registry.php on line 1012 maybe this irrelevant till run time? Anyway on to the review: yes: rpmlint. $ rpmlint php-ezc-Graph.spec \ ../RPMS/noarch/php-ezc-Graph-1.5-1.fc12.noarch.rpm \ ../SRPMS/php-ezc-Graph-1.5-1.fc12.src.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. yes: Named like the other php-ezc-* packages. yes: Spec file name matches pkg name. yes: Meets pkg guidelines. yes: Spec file states BSD. yes: Software licensed as New BSD (no advertising, 3 clause) yes: LICENSE file present. /usr/share/doc/php-ezc-Graph-1.5/docs/LICENSE yes: American eng yes: legible .spec. yes: souce matches URL. $ md5sum Graph-1.5.tgz SOURCES/Graph-1.5.tgz c8b5e0f3b28aad667154d65408453feb Graph-1.5.tgz c8b5e0f3b28aad667154d65408453feb SOURCES/Graph-1.5.tgz yes: package builds fine. yes: build requirements sane. yes: no locales. yes: No share libs. yes: No system libs. yes: Not relocatable. yes: Directories should be owned or pulled in. /usr/share/pear/.pkgxml owned by php-pear /usr/share/pear/data owned by php-pear /usr/share/pear/ezc owned by php-ezc-Base all are pulled in. yes: no file duplicates. yes: consistant macros. yes: %clean actually cleans. yes: There are quite a lot of doc files but only 1.9 Meg so fine. yes: %doc not needed. yes: No header files. yes: No gui. yes: no .la files. yes: Does not own directories belonging to other packages. yes: %install cleans first. All good package APPROVED. Steve. (I've a couple of packages up for review at the moment if you have time) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review