Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566695 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |rdieter@xxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> 2010-02-20 05:07:44 EST --- 1. Should add some Provides similar to what constantine-kde-theme has: %if 0%{?fedora} == 13 Provides: system-kde-theme = %{version}-%{release} Provides: system-kdm-theme = %{version}-%{release} Provides: system-ksplash-theme = %{version}-%{release} %endif (This can be addressed post review) 2. rpmlint: goddard-kde-theme.src: W: spelling-error %description -l en_US KSplash -> K Splash, KS plash, KS-plash goddard-kde-theme.noarch: W: spelling-error %description -l en_US KSplash -> K Splash, KS plash, KS-plash goddard-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/ksplash/Themes/Goddard/1400x1050/logo.png ../../../../../../pixmaps/system-logo-white.png goddard-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Goddard/system-logo-white.png ../../../../../pixmaps/system-logo-white.png goddard-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Goddard/goddard-1280x768.png ../../../../../backgrounds/goddard/default/wide/goddard.png goddard-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Goddard/goddard-1024x768.png ../../../../../backgrounds/goddard/default/standard/goddard.png goddard-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Goddard/goddard-1152x720.png ../../../../../backgrounds/goddard/default/wide/goddard.png goddard-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Goddard/goddard-1440x900.png ../../../../../backgrounds/goddard/default/wide/goddard.png goddard-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Goddard/goddard-1366x768.png ../../../../../backgrounds/goddard/default/wide/goddard.png goddard-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Goddard/goddard-1280x720.png ../../../../../backgrounds/goddard/default/wide/goddard.png goddard-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/ksplash/Themes/Goddard/1280x800/goddard.png ../../../../../../backgrounds/goddard/default/wide/goddard.png goddard-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Goddard/goddard-640x480.png ../../../../../backgrounds/goddard/default/standard/goddard.png goddard-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Goddard/goddard-1920x1200.png ../../../../../backgrounds/goddard/default/wide/goddard.png goddard-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Goddard/goddard-1200x900.png ../../../../../backgrounds/goddard/default/standard/goddard.png goddard-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Goddard/goddard-1920x1080.png ../../../../../backgrounds/goddard/default/wide/goddard.png goddard-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Goddard/goddard-1280x960.png ../../../../../backgrounds/goddard/default/standard/goddard.png goddard-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Goddard/goddard-1920x1440.png ../../../../../backgrounds/goddard/default/standard/goddard.png goddard-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/ksplash/Themes/Goddard/1400x1050/goddard.png ../../../../../../backgrounds/goddard/default/standard/goddard.png goddard-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Goddard/goddard-1024x600.png ../../../../../backgrounds/goddard/default/wide/goddard.png goddard-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Goddard/goddard-1152x864.png ../../../../../backgrounds/goddard/default/standard/goddard.png goddard-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Goddard/goddard-1440x1080.png ../../../../../backgrounds/goddard/default/standard/goddard.png goddard-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Goddard/goddard-800x600.png ../../../../../backgrounds/goddard/default/standard/goddard.png goddard-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Goddard/goddard-1600x1200.png ../../../../../backgrounds/goddard/default/standard/goddard.png goddard-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Goddard/goddard-1680x1050.png ../../../../../backgrounds/goddard/default/wide/goddard.png goddard-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Goddard/goddard.png ../../../../../backgrounds/goddard/default/standard/goddard.png goddard-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Goddard/goddard-1280x800.png ../../../../../backgrounds/goddard/default/wide/goddard.png goddard-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Goddard/goddard-800x480.png ../../../../../backgrounds/goddard/default/wide/goddard.png goddard-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Goddard/goddard-2048x1536.png ../../../../../backgrounds/goddard/default/standard/goddard.png 2 packages and 0 specfiles checked; 0 errors, 28 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review