Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=561086 --- Comment #9 from Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 2010-02-20 01:12:59 EST --- Looks good, with a couple recommendations: Given the recent issues with ExtUtils::MakeMaker and PERL_INSTALL_ROOT, you will probably want to replace PERL_INSTALL_ROOT with DESTDIR under %install. Please consider adding "%{?perl_default_filter}" to your spec, before the %description block; even if the addition is merely pro-forma for this package. It won't hurt anything and may well save some pain in the future. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2001007 Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly. Source tarballs match upstream (sha1sum): d90f5d2f7146905ce314fe8b295848c8ac3b934c String-Escape-2010.002.tar.gz d90f5d2f7146905ce314fe8b295848c8ac3b934c String-Escape-2010.002.tar.gz.srpm Final provides / requires are sane: 0 packages and 1 specfiles checked; 0 errors, 0 warnings. =====> perl-String-Escape-2010.002-3.fc13.noarch.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-String-Escape-2010.002-3.fc13.noarch.rpm perl(String::Escape) = 2010.002 perl-String-Escape = 2010.002-3.fc13 ====> requires for perl-String-Escape-2010.002-3.fc13.noarch.rpm perl(Carp) perl(Exporter) perl(:MODULE_COMPAT_5.10.1) perl(strict) perl(vars) perl(warnings) =====> perl-String-Escape-2010.002-3.fc13.src.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-String-Escape-2010.002-3.fc13.src.rpm ====> requires for perl-String-Escape-2010.002-3.fc13.src.rpm perl(ExtUtils::MakeMaker) perl(Test::More) perl(Test::Pod) perl(Test::Pod::Coverage) APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review