Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225884 Nalin Dahyabhai <nalin@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(nalin@xxxxxxxxxx) | --- Comment #2 from Nalin Dahyabhai <nalin@xxxxxxxxxx> 2010-02-19 16:32:57 EST --- (In reply to comment #1) > * MUST: rpmlint must be run on every package. The output should be posted > in the review.[1] > FAIL (the changelog should be fixed) Whoops, fat-fingered that last one, didn't I? > hesiod.src: W: name-repeated-in-summary Hesiod > The name of the package is repeated in its summary. This is often redundant > information and looks silly in various programs' output. Make the summary > brief and to the point without including redundant information in it. I'm open to suggestions, but every alternative I come up with is much longer than one line of text. > hesiod.src: W: no-url-tag > The URL tag is missing. There's no upstream project page of which I'm aware. > hesiod.src: W: patch-not-applied Patch0: hesiod-3.1.0-classes.patch > A patch is included in your package but was not applied. Refer to the patches > documentation to see what's wrong. Dropped. At the time I didn't know if upstream would be restoring something like it, but it hasn't happened yet. > hesiod.x86_64: W: name-repeated-in-summary Hesiod > The name of the package is repeated in its summary. This is often redundant > information and looks silly in various programs' output. Make the summary > brief and to the point without including redundant information in it. It's used once, in the sentence which describes what it is. I think this use should be allowed. > hesiod.x86_64: W: incoherent-version-in-changelog 3.1.0-15 ['3.1.0-18.fc12', > '3.1.0-18'] > The last entry in %changelog contains a version identifier that is not > coherent with the epoch:version-release tuple of the package. Fixed. > hesiod.x86_64: W: no-url-tag > The URL tag is missing. > > hesiod-debuginfo.x86_64: W: no-url-tag > The URL tag is missing. > > hesiod-devel.x86_64: W: no-url-tag > The URL tag is missing. Based on discussion in #225883, I'm not sure there's anything good to be used here (I'd be tempted to point at, say, Wikipedia's article, or glibc's README.hesiod, but > # SHOULD: The reviewer should test that the package functions as described. A > package should not segfault instead of running, for example. > Not done (No available Hesiod/DNS server setup) If you have a DNS server handy, you can use http://git.fedoraproject.org/git/splatbind.git?p=splatbind.git;a=blob_plain;f=misc/migrate_hesiod.sh to produce a zone file. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review