Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566686 --- Comment #2 from Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 2010-02-19 13:32:37 EST --- Looks good. perl(Test::Pod) should be br'ed to run the t/pod.t. Think about including %{?perl_default_filter} by default, even if just pro forma. It won't hurt anything and might save some pain down the line. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1999991 Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly. Source tarballs match upstream (sha1sum): 1bdcb5104e9288cc01f24343824d8646eb25c947 Olson-Abbreviations-0.02.tar.gz 1bdcb5104e9288cc01f24343824d8646eb25c947 Olson-Abbreviations-0.02.tar.gz.srpm Final provides / requires are sane: 0 packages and 1 specfiles checked; 0 errors, 0 warnings. =====> perl-Olson-Abbreviations-0.02-1.fc13.noarch.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-Olson-Abbreviations-0.02-1.fc13.noarch.rpm perl(Olson::Abbreviations) = 0.02 perl-Olson-Abbreviations = 0.02-1.fc13 ====> requires for perl-Olson-Abbreviations-0.02-1.fc13.noarch.rpm perl(:MODULE_COMPAT_5.10.1) perl(Moose) perl(MooseX::AttributeHelpers) perl(MooseX::ClassAttribute) perl(strict) perl(warnings) =====> perl-Olson-Abbreviations-0.02-1.fc13.src.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-Olson-Abbreviations-0.02-1.fc13.src.rpm ====> requires for perl-Olson-Abbreviations-0.02-1.fc13.src.rpm perl(ExtUtils::MakeMaker) perl(Moose) perl(MooseX::AttributeHelpers) perl(MooseX::ClassAttribute) perl(Test::More) APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review