Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=565958 timlank <timlank@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |timlank@xxxxxxxxxxx --- Comment #3 from timlank <timlank@xxxxxxxxxxx> 2010-02-19 13:14:30 EST --- (I'm not a sponsor, just a fellow requestor trying to perform a peer review so that I can also get sponsored) rpmlint -v of SPECfile and SRPM: # rpmlint -v SynapticsConfig.spec SynapticsConfig-0.1.3-1.src.rpm SynapticsConfig.spec:23: W: setup-not-quiet SynapticsConfig.spec: W: no-cleaning-of-buildroot %install SynapticsConfig.src: I: checking SynapticsConfig.src:23: W: setup-not-quiet SynapticsConfig.src: W: no-cleaning-of-buildroot %install 1 packages and 1 specfiles checked; 0 errors, 4 warnings. It would appear that your .SPEC needs some cleanup.... 1. remove the %defines at the top for the version, name, release and put them directly in the corresponding tags (Name, Version, Release) 2. not 100% sure about the "unmangled_version" - suspect it needs to go away in favor of a straight "version" 3. It's complaining about the setup -n...... once you perform step 1 above, you can replace this simply with a %setup -q and the rpmlint warning disappears 4. the Source0 should be a publicly accessible URL to the source code I think rather than just the local filename 5. I think you need to leave out the Vendor tag 6. the %install section needs to clean the buildroot - rm -rf %{buildroot} This is an initial pass at the SPEC. I'll try to delve more into a review over the next day or two... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review