Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508750 Rahul Sundaram <metherid@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |metherid@xxxxxxxxx --- Comment #14 from Rahul Sundaram <metherid@xxxxxxxxx> 2010-02-18 09:03:05 EST --- http://sundaram.fedorapeople.org/packages/trash-cli.spec http://sundaram.fedorapeople.org/packages/trash-cli-0.11.2-1.fc12.src.rpm Buildroot definition and cleaning of buildroot is not necessary according to current guidelines http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag No recent version of RPM and Fedora setup requires either and rpmlint warnings can be ignored in this case Of note trash was renamed to trash-cli primarily based on opposition from Fedora on a short name so renaming it now again would be pointless and I will inform upstream to update the doc to maintain consistency I have updated other things as per comments and thanks for the review -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review