Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=565858 --- Comment #10 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-02-18 03:38:20 EST --- For -3: (Maybe you seem to based your spec file on rubygem-nokogiri spec file) * Unneeded recompilation ----------------------------------------------------------------- pushd ./%{geminstdir} find . -name \*.so -or -name \*.o -exec rm -f {} \; rake -v compile --trace ----------------------------------------------------------------- - is unneeded. Building C module (thin_parser.so) is already done in %prep correctly ( for rubygem-nokogiri, gem install uses -O3 optimization level, while Fedora uses -O2, so recompilation is needed ) * "Moving" C module to %ruby_sitearch ------------------------------------------------------------------ 59 cp %{buildroot}%{geminstdir}/lib/*.so %{buildroot}%{ruby_sitearch}/%{gemname}/ ------------------------------------------------------------------ - This should be: ------------------------------------------------------------------ mv %{buildroot}%{geminstdir}/lib/*.so %{buildroot}%{ruby_sitearch}/ ------------------------------------------------------------------ ( arch specific binary should be "moved" to %ruby_sitearch. Also Originally this C module (thin_parser.so is under %geminstdir/lib, not under %geminstdir/lib/%gemname ) (In reply to comment #2) > (In reply to comment #1) > > - As this gem contains spec/ directory, please add %check > > section and execute some test program (like $ rake spec ) there. > > Actually, 'rake spec' produce 1 failure, which is relevant to Ruby version. We > could omit this safely for now IMHO. > (Also it raising some weird Ruby crashes [1]) - Then please kill these tests for now and enable tests. * License (In reply to comment #2) > (In reply to comment #1) > > - It seems that license tag should be "MIT and BSD and (Ruby or GPLv2)", > > however I will recheck this later. > > Regarding to thin web page[2], licence is: "Ruby License, > www.ruby-lang.org/en/LICENSE.txt." - However "COPYING" file is clearly MIT, and actually ------------------------------------------------------------------- MIT ./COPYING ./spec/rails_app/public/ BSD ./lib/thin/stats.html.erb GPLv2 or Ruby (note: ruby is licensed under "GPLv2 or Ruby" in Fedora's term) ./README And some others ------------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review