Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562993 --- Comment #2 from Mohammed Morsi <mmorsi@xxxxxxxxxx> 2010-02-17 16:21:46 EST --- (In reply to comment #1) > Some notes: > > * Macros > - Defined %ruby_sitelib is used nowhere > - Please use defined %geminstdir also in %files Done > > * ruby(abi) dependency > - "Requires: ruby(abi) = 1.8" dependency is missing > https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines Done > > * License > -------------------------------------------------------- > Overall: MIT > > GPLv2 or Ruby > ./lib/yard/parser/c_parser.rb > -------------------------------------------------------- > - License tag should be "MIT and (GPLv2 or Ruby)". Done > > * SourceURL > - We usually use http://gems.rubyforge.org/gems/%{gemname}-%{version}.gem gemcutter has recently replaced rubyforge as the default/official rubygem gem hosting location and thus I'm thinking we should get all our rubygem packages from there from now on http://update.gemcutter.org/2009/10/26/transition.html > > * Documents > - "ChangeLog", "LICENSE", "README.md" under %geminstdir should properly be > marked as %doc (and we usually also mark Rakefile as %doc) > - Also benckmarks/ docs/ spec/ templates/ directories can be marked > as %doc > (and please consider to split these files/directories into -doc > subpackage) > > * %check > - As this package contains spec/ directory, please add %check section > and execute some test program (like $ rake spec) there. Both done Updated and uploaded new rubygem-yard rpm Spec URL: http://mo.morsi.org/files/gems/rubygem-yard.spec SRPM URL: http://mo.morsi.org/files/gems/rubygem-yard-0.5.3-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review