Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=565858 --- Comment #2 from Michal Fojtik <mfojtik@xxxxxxxxxx> 2010-02-17 08:13:41 EST --- (In reply to comment #1) > Some quick notes > > - build fails, at least BR: ruby-devel is needed > http://koji.fedoraproject.org/koji/taskinfo?taskID=1990997 FIXED: http://koji.fedoraproject.org/koji/taskinfo?taskID=1993283 > > - C extension modules should be installed under %ruby_sitearch, > not under %geminstdir FIXED (this applies only to thin_parse.so) > - To create debuginfo rpms correctly, you once have to install gem file > under %_builddir (i.e. you cannot install this gem file under > %buildroot directory, otherwise creating debuginfo rpm fails: > > FIXED (?) Not sure. > > - As this gem contains spec/ directory, please add %check > section and execute some test program (like $ rake spec ) there. Actually, 'rake spec' produce 1 failure, which is relevant to Ruby version. We could omit this safely for now IMHO. (Also it raising some weird Ruby crashes [1]) > > - Please use defined %geminstdir macro in %files FIXED > > - "CHANGELOG" "COPYING" "README" (and usually also "Rakefile") should > correctly marked as %doc. > Also benchmark/ example/ spec/ tasks/ directories can perhaps be > marked as %doc. All doc-relevant files was marked as 'doc' > - ext/ directory are to compile C extention module (thin_parser.so) > and need not be packaged into binary rpm. FIXED > - It seems that license tag should be "MIT and BSD and (Ruby or GPLv2)", > however I will recheck this later. Regarding to thin web page[2], licence is: "Ruby License, www.ruby-lang.org/en/LICENSE.txt." Spec URL: http://mifo.sk/rubygem-thin.spec SRPM URL: http://mifo.sk/rubygem-thin-1.2.5-2.fc12.src.rpm [1] https://bugzilla.redhat.com/show_bug.cgi?id=566153) [2] http://code.macournoyer.com/thin/doc/files/README.html -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review