Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=561448 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-02-16 13:37:25 EST --- Some initial notes: * Using %{version} - Using %{version} in Source0 is useful (especially when version is upgraded): https://fedoraproject.org/wiki/Packaging/SourceURL#Using_.25.7Bversion.7D * EVR (Epoch-Version-Release) specific java dependency - I guess you want "BR: java-devel >= 1:1.6.0" if you want Java OpenJDK https://fedoraproject.org/wiki/Packaging/Java#BuildRequires_and_Requires - And for consistency I guess java Requires (not BuildRequires) should also be EVR specific. * Fedora specific compilation flags - Fedora specific compilation flags are not honored. ------------------------------------------------------------------- 100 -build-native-library: 101 [exec] cc -m32 -O2 -fno-omit-frame-pointer -fno-strict-aliasing -DNDEBUG -W -Werror -Wall -Wno-unused -Wno-parentheses -Wundef -I"/builddir/build/BUILD/jffi-0.6.2/build/jni" -I"/builddir/build/BUILD/jffi-0.6.2/build/jni"/jni -I/builddir/build/BUILD/jffi-0.6.2/jni -I"/builddir/build/BUILD/jffi-0.6.2/jni/jffi" -fPIC -I"/usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0/jre/../include" -I"/usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0/jre/../include/linux" -I/usr/lib/libffi-3.0.9/include -D_REENTRANT -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -pthread -march=i586 -mtune=generic -c /builddir/build/BUILD/jffi-0.6.2/jni/jffi/Array.c -o /builddir/build/BUILD/jffi-0.6.2/build/jni/jffi/Array.o ------------------------------------------------------------------- You can check the current compilation flags by $ rpm --eval %optflags https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags * jni-containing jar file location - This jar file uses jni and should be installed under %_libdir/%name https://fedoraproject.org/wiki/Packaging/Java#Packaging_JAR_files_that_use_JNI * Using ln - For this please see my comment on bug 561482. * Documents - "COPYING" file (i.e. GPLv3 license text) should be also added to %doc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review