Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=565811 --- Comment #6 from Michal Fojtik <mfojtik@xxxxxxxxxx> 2010-02-16 11:33:00 EST --- (In reply to comment #5) > Quick notes: > > - README.rdoc says that license is under MIT FIXED > - build.log says there is some duplicate %files entry, > please fix this (this is a MUST item) > https://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles FIXED > - Now we prefer to use %global over %define FIXED > > https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define > - Please use %geminstdir macro in %files list because you have > explicitly defined this. FIXED Thanks for all suggestions Mamoru! Spec URL: http://mifo.sk/rubygem-rest-client.spec SRPM URL: http://mifo.sk/rubygem-rest-client-1.3.1-1.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review