[Bug 565502] Review Request: python-recaptcha-client - A plugin for reCAPTCHA and reCAPTCHA Mailhide

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=565502

Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomspur@xxxxxxxxxxxxxxxxx

--- Comment #3 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-02-15 17:45:51 EST ---
There are also some other issues:

- use %global and not %define
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define

- Buildrequires/requires: python is added automatic

- Could you please be a bit more specific in %files?
  When you use %{python_sitelib}/recaptcha_client-*.egg-info and
%{python_sitelib}/recaptcha you are notified if the egg can't be build.

- Where is this spec file based on?
  When you run "rpmdev-newspec -t python python-recaptcha-client" you could use
that spec file as a starting point.

e.g. from %install
%{__python} setup.py install -O1 --skip-build --root %{buildroot}

You don't have this --skip-build in your spec. Please add this, because this is
part of convention in all python packages.
https://fedoraproject.org/wiki/Packaging:Python

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]