[Bug 550582] Review Request: dpkg - Package maintenance system for Debian Linux

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550582

--- Comment #20 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2010-02-14 15:05:18 EST ---
Thanks.

(In reply to comment #19)
> 
> * Directory ownership fixed

Still there are issues. Please install all the generated packages. Then
uninstall them. You will be left with these empty directories
   /usr/lib/perl5/vendor_perl/5.10.0/Dpkg/
   /usr/lib/perl5/vendor_perl/5.10.0/Debian/
   /usr/share/dpkg/
That is because their subdirectories are not owned. And rpm does not remove
non-empty directories during uninstallation.

An example of a way to fix this is to change the lines
   %dir %{perl_vendorlib}/Debian
   %{perl_vendorlib}/Debian/Dselect/*.pm
to
   %{perl_vendorlib}/Debian/
then you won't have this problem. Similarly for the other directories. Beware
though, %{_datadir}/dpkg/ is used by both the main package and the dselect
package so it needs to be handled carefully.

Also, you have these two lines under %files:
   %dir %{_datarootdir}/dpkg
   %dir %{_datadir}/dpkg
As far as I know, %{_datarootdir} and %{_datadir} both point to /usr/share.
There is no need to list the same directory twice in the %files listings. I
prefer using either one notation or the other.

> 
> * Please provide some pointers on how i can make the build more verbose.
> 

Just pass --disable-silent-rules to configure.

! One last thing:
Changing
   install -m0644
to
   install -pm0644
will preserve timestamps. No big deal though.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]