[Bug 563510] Review Request: php-xcache - yet another php cacher

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=563510

Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora@xxxxxxxxxxxxxxxxx

--- Comment #15 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> 2010-02-13 11:49:50 EST ---
Quick notes

- don't understand why you try to register this as a pecl extension (%post /
%postun). 
This is not a pecl extension, and you don't have the package.xml file required
for this.


- so, could also be removed
%global pecl_name xcache
Requires(post): %{__pecl}
Requires(postun): %{__pecl}
Provides:      php-pecl(%{pecl_name}) = %{version}


- xcache.ini 
zend_extension = /EXT_DIR/xcache.so
no need to give full path.


- %defattr(-, root, root, 0755)
(-,root,root,-) must be enough. php script should be 644 
This will remove a lot of rpmlint message
php-xcache.x86_64: E: script-without-shebang /usr/share/php-xcache/admin/...


- admin / coverager
You need to create a alias (httpd/conf.d) to give access to admin URL.
probably also need a writable dir for xcache.coveragedump_directory

If you don't want to make this available, don't install it, just add it in %doc

- INSTALL
don't need this file in RPM

- Buildroot
is acceptable, but read
http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]