Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=556308 --- Comment #6 from Nicolas Mailhot <nicolas.mailhot@xxxxxxxxxxx> 2010-02-13 11:17:10 EST --- (In reply to comment #5) > First, one cosmetic nitpick: > $ rpm -qivp SRPMS/paratype-pt-sans-fonts-20100112-1.fc12.src.rpm > [snip] > This package includes the four basic styles and two narrows styles for \ > economic setting. > > Could you make the backslash go away? Stupid mistake, sorry about it, fixed > +:ok, =:needs attention, -:needs fixing > > MUST Items: > [+] MUST: rpmlint must be run on every package. > $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/paratype-pt-sans-* > paratype-pt-sans-caption-fonts.noarch: W: invalid-license PTFL rpmlint is not up-to-date, PTFL is on the official Fedora license list http://fedoraproject.org/wiki/Legal_considerations_for_fonts#Approved_font_licenses > paratype-pt-sans-caption-fonts.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/paratype-pt-sans-caption-fonts-20100112/PT Free Font > License_eng.txt > paratype-pt-sans-caption-fonts.noarch: W: file-not-utf8 > /usr/share/doc/paratype-pt-sans-caption-fonts-20100112/PT Free Font > License_eng.txt Missed it with all the stupid spellchecking warnings, fixed (sorry about it, I'm usually better than that) > paratype-pt-sans-fonts.src: W: macro-in-%description %_font_pkg This is a bug in rpmlint & rpmbuild > [-] MUST: The sources used to build the package must match the upstream source, > as provided in the spec URL. > => First one is the one I got from the URL in the spec file, second one is > from the SRPM. > $ sha1sum PTSans.zip > d812b275f2b13e59a69671785b53a4eb5805c561 PTSans.zip > $ sha1sum SOURCES/PTSans.zip > f72ab3c42157ef81f7398b641213851f77e2deec SOURCES/PTSans.zip Upstream probably did the usual in-place archive update (very common for fonts), I'll use the new version. > This package is not approved as the source archives don't match. Fixed http://nim.fedorapeople.org/paratype-pt-sans-fonts-20100112-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review