Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=564537 Terje Røsten <terjeros@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |terjeros@xxxxxxxxxxxx --- Comment #1 from Terje Røsten <terjeros@xxxxxxxxxxxx> 2010-02-13 07:52:24 EST --- Some comments: Release: 0.1%{?dist}.svac Why so uncommon release tag, what't wrong with 1%{?dist}? %build - Add a comment about why %build in empty. %install rm -rf $RPM_BUILD_ROOT %{_builddir}/grc-1.3/install.sh %{_builddir}/grc-1.3/ $RPM_BUILD_ROOT - %install will cd into source dir, you should use: ./install.sh $RPM_BUILD_ROOT I don't understand why you need the build patch, (which is a install patch:-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review