Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560071 --- Comment #12 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> 2010-02-12 12:49:06 EST --- Ok, version 0.6.1 fix apache segfault. REVIEW : + rpmlint is ok php-pecl-augeas.src: I: checking php-pecl-augeas.x86_64: I: checking php-pecl-augeas-debuginfo.x86_64: I: checking 3 packages and 1 specfiles checked; 0 errors, 0 warnings. + package is named according to the Package Naming Guidelines . + spec file name + The package must meet the Packaging Guidelines and PHP Guidelines + license ok (PHP) and match upstream + license provided + spec file is legible + sources match upstream 44859bbe4da82b88d18f41489495c3a3 augeas-0.6.1.tgz + source URL ok + build on F12 x86_64 (php 5.3.2RC2) + build on mock/koji (F12 ref in previous post) + build on all arch (F11, i386, x86_64, ppc, and ppc64) http://koji.fedoraproject.org/koji/taskinfo?taskID=1980430 + BuildRequires + no locale + no shared library (extension are not lib.) + no system library + own all directories that it creates + not list a file more than once in the spec + Permissions on files are set properly. + %clean ok + consistently use macro + contain code + small doc, no sub package + doc not required to run + no -devel + no -static + no .pc + no .la + not own files or directories already owned by other packages + %install start with rm -rf $RPM_BUILD_ROOT + all files are UTF-8 + %check ok (only load test) + PHPUnit suite ok (after install) OK (14 tests, 19 assertions) + load correctly with httpd Should : ask upstream ;) if possible to split README into INSTALL + README, because INSTALL instruction could be removed from RPM (for the next release) *** APPROVED *** Of course, you need to wait for your "packager" status approval before asking for CVS. That's why I didn't put the review flag + now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review