Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530251 --- Comment #12 from Tim Niemueller <tim@xxxxxxxxxxxxx> 2010-02-11 16:00:19 EST --- Here is my quick review. I have asked Jeff Spaleta to go over this as well. He agreed to do so, and he can sponsor you if he deems the packages acceptable. MUST * OK: rpmlint * OK: package name * OK: package version and release * OK: spec file name * OK: package guideline-compliant * OK: license complies with guidelines * OK: license field accurate * OK: license file not deleted * OK: spec in US English * OK: spec legible * OK: source matches upstream sha256sum 12170be6b6c477926eb4e274574d877b4ccd7230978088a61b892e6f1dbb6e08 * OK: builds under >= 1 archs, others excluded * OK: dependencies (requires) * OK: build dependencies complete * N/A: locales handled using %find_lang, no %{_datadir}/locale * OK: library -> ldconfig * N/A: relocatable: give reason * OK: own all directories * OK: no dupes in %files * OK: permission * OK: %clean RPM_BUILD_ROOT * OK: macros used consistently * OK: Package contains code * N/A: large docs => -doc * N/A: doc not runtime dependent * OK: headers in -devel * N/A: static in -static * OK: if contains *.pc, req pkgconfig * OK: if libfiles are suffixed, the non-suffixed goes to devel * OK: devel requires versioned base package * N/A: desktop file uses desktop-file-install * OK: clean buildroot before install * OK: filenames UTF-8 SHOULD * OK: if license text missing, ask upstream to include it * N/A: desc and summary contain translations if available * OK: package build in mock on all architectures Koji URLs given by packager * OK: package functioned as described Did tests with the Hokuyo laser range finder and worked just fine * OK: scriplets are sane * OK: other subpackages should require versioned base * N/A: if main pkg is development-wise, pkgconfig can go in main package * OK: require package not files I'm happy with the package and the parts I could test work here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review