Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=561235 --- Comment #2 from Hiemanshu Sharma <hiemanshu@xxxxxxxxx> 2010-02-11 13:54:26 EST --- - Package meets naming guidelines 0 Spec file matches base package name. 0 Spec has consistant macro usage. - Meets Packaging Guidelines. 0 License 0 License field in spec matches 0 License file included in package 0 Spec in American English 0 Spec is legible. 0 Sources match upstream md5sum: 9d5e68fa1af1f4d91da34e76ed95fe19 phpESP-2.1.1.tgz * Package needs ExcludeArch 0 BuildRequires correct * Spec handles locales/find_lang * Package is relocatable and has a reason to be. 0 Package has %defattr and permissions on files is good. 0 Package has a correct %clean section. x Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) 0 Package is code or permissible content. * Doc subpackage needed/used. 0 Packages %doc files don't affect runtime. * Headers/static libs in -devel subpackage. * Spec has needed ldconfig in post and postun * .pc files in -devel subpackage/requires pkgconfig * .so files in -devel subpackage. * -devel package Requires: %{name} = %{version}-%{release} * .la files are removed. * Package is a GUI app and has a .desktop file 0 Package compiles and builds on at least one arch. 0 Package has no duplicate files in %files. 0 Package doesn't own any directories other packages own. 0 Package owns all the directories it creates. 0 No rpmlint output. [False Positive] 0 final provides and requires are sane: Provides: phpesp-2.1.1-1.fc12.noarch.rpm config(phpesp) = 2.1.1-1.fc12 phpesp = 2.1.1-1.fc12 Requires: /bin/sh /usr/bin/perl config(phpesp) = 2.1.1-1.fc12 perl(strict) php >= 4.2.1 php-adodb php-gettext rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 webserver rpmlib(PayloadIsXz) <= 5.2-1 SHOULD Items: - Should build in mock. 0 Should build on all supported archs 0 Should function as described. 0 Should have sane scriptlets. * Should have subpackages require base package with fully versioned depend. 0 Should have dist tag 0 Should package latest version * check for outstanding bugs on package. (For core merge reviews) [-] To be checked [x] Need fixing [*] NA [0] Checked -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review