Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563673 --- Comment #5 from Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> 2010-02-11 08:25:09 EST --- (In reply to comment #1) > How about the "Provides: fonts-sil-abyssinica"? (bug 563395) I thought I'd not mix this in the renaming, that if I only did the renaming then the review would be easier. I was planning to fix it afterwards, but if you feel like I should fix it in the same time, then let's go :) > Also can you reproduce: > > # note current downloaded filename is lowercase > > and if so how about renaming the source file? I assumed the source tarball had not changed. I'll take a look at it. (In reply to comment #2) > Yeah, your call I think, but it might not hurt for people > familiar with the old name. You might add a comment > say "# added for f13 can be removed for f15". Good idea. I will do that. (In reply to comment #4) > Ah also please upload the srpm for reference. :) Doh, why did I upload the binary rpm instead of the src.rpm ? oÔ I scratch-built it in Koji before uploading it to my FedoraPeople space (I don't know how long scratch builds are kept). Here it is: http://koji.fedoraproject.org/koji/getfile?taskID=1976022&name=sil-abyssinica-fonts-1.0-6.fc13.src.rpm Anyway, I'll upload a -7 SRPM with your suggestions tonight. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review