Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563510 Till Maas <opensource@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |opensource@xxxxxxxxx --- Comment #10 from Till Maas <opensource@xxxxxxxxx> 2010-02-11 06:39:24 EST --- (In reply to comment #9) > (In reply to comment #4) > > * some code in SPEC is commented out, decreases readability. Why don't you > > remove those lines? Why is code for RHEL 4 and RHEL 5 included? > fixed It's good to remove the commented out lines, but if there is a chance that this package can be included in EPEL[0], then the rhel conditionals are helpful. [0] https://fedoraproject.org/wiki/EPEL -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review