Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xerces-c - Validating XML Parser https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210553 ------- Additional Comments From rc040203@xxxxxxxxxx 2006-10-13 08:56 EST ------- Some further remarks: - A nasty typo had crept into your spec through my patch: search for "fine" and replace it with "find", sorry. - You should install the samples into %{_datadir}, instead of %{_prefix}/share - %{_datadir}/%{_name} is unowned - Building the samples after installation does not work. AFAIS, their configuration needs to be prepared for building outside of the source tree, and therefore would require further tweaks to make them buildable. - /usr/share/xerces-c/samples/Projects contains VC project files. These are meaningless on Fedora. - rpmlint xerces-c-devel W: xerces-c-devel summary-ended-with-dot Header files, libraries and development documentation for xerces-c. - xerces-c-samples contains code-examples. If you can get them buildable I'd let it "Requires: xerces-c-devel", alternatively (esp. if you can't get them buildable) you could consider to move them into the *-devel's docs. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review