Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=558685 Julian Sikorski <belegdol@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #10 from Julian Sikorski <belegdol@xxxxxxxxx> 2010-02-10 15:16:57 EST --- 1. rpmlint is silent: rpmlint gloobus-preview-0.4.1-5.fc12.src.rpm ../RPMS/x86_64/gloobus-preview-* 3 packages and 0 specfiles checked; 0 errors, 0 warnings. 2. Name is correct. 3. Spec file name is correct. 4. Package meets packaging guidelines 5. Licensing is OK: GPLv3. 6. Spec is written in American English and is legible. 7. Sources match upstream: d41d8cd98f00b204e9800998ecf8427e 8. Builds fine for f13: https://koji.fedoraproject.org/koji/taskinfo?taskID=1975674 9. BuildRequires are correct. 10. There is no locale to handle. 11. Shared libs are private, no need for ldconfig. 12. Nothing is bundled. 14. Not relocatable. 15. Ownerships are correct. 16. No duplicates in %files. 17. Permissions are correct. 18. %clean section is present. 19. Macros are consistent. 20. Package contains code. 21. No large doc. 22. %doc is not required at runtime. 23. No header files static libs nor pkgconfig files. 24. Libtool archives are removed. 25. Desktop file is included and validated. 26. Buildroot is cleaned at the beginning of %install. 27. Filenames are utf-8. 28. Package seems to work correctly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review