[Bug 560172] Review Request: jvyamlb - YAML processor for JRuby

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=560172

Mohammed Morsi <mmorsi@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mmorsi@xxxxxxxxxx

--- Comment #1 from Mohammed Morsi <mmorsi@xxxxxxxxxx> 2010-02-08 14:19:55 EST ---
Looks good for most part, builds find in mock and passes most review
guidelines. 

A couple of specifics though:

The following line doesn't work as intended:
find -name '*.jar' -o -name '*.class' -exec rm -f '{}' \;

You can replace it w/ this:
find \( -name '*.jar' -o -name '*.class' \) -exec rm -rf {} \;


As far as the changelog you have a typo, "Jun 2010" should be "Jan 2010". 

Also why did you remove the previous entries from the changelog
http://cvs.fedoraproject.org/viewvc/rpms/jvyamlb/F-11/jvyamlb.spec?view=markup

Also I didn't try, but if it works w/ gcj (java-devel >= 1.5) adding gcj
support to the spec is relatively easy:
http://fedoraproject.org/wiki/Packaging/GCJGuidelines

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]