Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560170 --- Comment #4 from Mohammed Morsi <mmorsi@xxxxxxxxxx> 2010-02-08 13:49:17 EST --- Looks good for most part, builds find in mock/koji and passes most review guidelines. A couple of specifics though: Even though this is in the orphaned specfile, the following line doesn't work (try it yourself): find -name '*.jar' -o -name '*.class' -exec rm -f '{}' \; You can replace it w/ this if you want: find \( -name '*.class' -o -name '*.jar' \) -exec rm -rf {} \; or this: find ./ -name '*.jar' -exec rm -f '{}' \; find ./ -name '*.class' -exec rm -f '{}' \; As far as the changelog you have a typo, "Jun 2010" should be "Jan 2010". Also why did you remove the previous entries from the changelog http://cvs.fedoraproject.org/viewvc/rpms/jcodings/F-11/jcodings.spec?view=markup I would leave those in and add a bit about gcj support being removed for jcodings. I had tried getting gcj/jcodings working myself to no avail, aot-compile-rpm blocks indefinetly, consuming more and more resources. If you can figure out the problem, adding gcj support is easy, if not just add a note to the changelog. http://fedoraproject.org/wiki/Packaging/GCJGuidelines -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review