Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=545408 --- Comment #4 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-02-08 13:37:47 EST --- - debuginfo: cmake does not use the %{optflags}, same like above: query upstream about this or try to patch it on your own. (Unfortunately, I can't help here, my cmake knowledge is a bit limited ;)) - %files: You have %{_datadir}/scantailor/ Please delete all subfiles/folders like the translations. The following is translated as "warning: file listed twice:" Warnung: Datei doppelt aufgelistet: /usr/share/scantailor/translations/scantailor_bg.qm Warnung: Datei doppelt aufgelistet: /usr/share/scantailor/translations/scantailor_ru.qm - rest looks ok now. - license is ok with GPLv3+, because, anything installed is GPLv3+ and it's the least common set anyway. - Could you please add running the testsuite? e.g. 54 %check 55 make tests 56 ./tests/tests ##################y - Could you query upstream and ask about patching, that the CFLAGS are honored? - Please bump the release, when making changes the next time, so changes are also visible. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review