Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560071 --- Comment #7 from Pedro Padron <ppadron@xxxxxxxxxx> 2010-02-08 09:45:36 EST --- Remi, thanks for the comments! Here's the changelog for the new release: * Mon Feb 08 2010 Pedro Padron <ppadron@xxxxxxxxxx> - 0.6.0-2 - Changes based on initial package review by Remi Collet - Added CREDITS file - Removed explicit "Requires: augeas-libs" - Changed "Requires: php" to "Requires: php-common >= 5.2.0" - Removed conditional Requires for php(api) - Added check section with a module load test - pecl_name and __install macros are now used properly About the tests, I added the load test you suggested. For the next release (0.7.0) I'll convert the PHPUnit tests to .phpt, which makes more sense when it comes to PECL extensions. I believe that the Wiki entry about PHP packaging could use an update based on your comments. I'll try to do that today (don't know if I can actually edit the page, though). http://fedoraproject.org/wiki/Packaging/PHP Here are the new links: SPEC URL: http://ppadron.blog.br/rpm/specs/php-pecl-augeas.spec SRPM URL: http://ppadron.blog.br/rpm/srpms/php-pecl-augeas-0.6.0-2.fc12.src.rpm Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=1968752 Just a question... Your rpmlint output differs from what I got here. Even for the first release, rpmlint did not complain about anything. Do you have additional filters? Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review