Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=561470 --- Comment #8 from Michael Schwendt <mschwendt@xxxxxxxxx> 2010-02-08 07:55:40 EST --- > BuildArch: noarch > %{_libdir}/%{name}/python/rlMemAvg.py* Bzzz! Noarch plus %_libdir won't fly, since the value of %_libdir would change with the build host. > Source0: %{name}-%{version}.tar.gz This is no valid URL where to download the tarball. If the tarball cannot be downloaded anywhere, please add a comment on how to construct it from a scm repository. > https://fedorahosted.org/git/beakerlib.git That redirects to: https://fedorahosted.org/web/410 No such project. The requested project does not exist on Fedora Hosted. > Obsoletes: rhtslib beaker-lib > Provides: rhtslib beaker-lib Have you tried "rpmlint -i ..." on the rpms? It's common practise to specify a max. version in Obsoletes tags in order to not occupy a namespace completely. And to specify an explicit EVR in Provides. Example: Obsoletes: rhtslib < 1.0 Provides: rhtslib = %{version}-%{release} If not doing that, this pair of Obsoletes/Provides becomes much more questionable. Look! On Fedora 12: $ repoquery --whatprovides rhtslib $ repoquery --whatprovides beaker-lib $ Nothing provides these so far. Even if it may be "old names": IMO, it's being frowned upon to provide alternative virtual package names just for fun. My suggestion: keep the Obsoletes with proper max. version, but don't add the Provides. It's silly to run with multiple alternative/competing packages names, whether virtual or not. > %makeinstall DESTDIR=$RPM_BUILD_ROOT Please prefer "make DESTDIR=$RPM_BUILD_ROOT install" over %makeinstall unless the normal "make install ..." doesn't work. The macro redefines many values, which bears a risk. > /usr/lib/beakerlib/python/journal-compare.py* Which packages owns /usr/lib/beakerlib/python/? > /usr/lib/beakerlib/perl/deja-summarize Which packages owns /usr/lib/beakerlib/perl/? http://fedoraproject.org/wiki/Packaging:UnownedDirectories > %{_mandir}/man1/beakerlib*1.gz Since man pages typically are compressed transparently by rpmbuild, prefer a wildcard over a file extension such as .gz: %{_mandir}/man1/beakerlib*1* -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review