Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562158 Ondrej Vasik <ovasik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? --- Comment #1 from Ondrej Vasik <ovasik@xxxxxxxxxx> 2010-02-05 08:54:57 EST --- Just few initial comments before review: - as you are upstream, it will be perfect to add version to the tarball name - you will prevent shaxxx/md5sum mismatches in the future updates. - please consider some manpage for the script (maybe just a bit tweaked README file) - Although BuildRoot is no longer really used, BuildRoot: %{_tmppath}/dfish-root is not allowed, please fix it to something like %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) - %doc README CHANGELOG COPYING should be sufficient - you don't need mkdir -p $RPM_BUILD_ROOT/%{_docdir}/%{name} install -m 644 README COPYING CHANGELOG $RPM_BUILD_ROOT/%{_docdir}/%{name} in install section - once you add version to the tarball name (and do a tarball with versioned directory), you will need just setup -q in prep section Please fix those issues. TIA. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review