Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=561253 --- Comment #6 from Peng Huang <phuang@xxxxxxxxxx> 2010-02-04 02:47:20 EST --- Package Review + package builds in mock (rawhide noarch). http://koji.fedoraproject.org/koji/taskinfo?taskID=1962396 + rpmlint is no errors and warnings + source files match upstream url 939e3d5f68946dfecedb737954f15c24 ibus-xkbc-1.2.0.20100115.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package does not contain code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + No update-gtk-immodules scriptlets present. + no duplicates in %files. + file permissions are appropriate. + no Desktop files. + Package => ibus-xkbc-1.2.0.20100115-2.fc13.noarch.rpm Provide: ibus-xkbc = 1.2.0.20100115-2.fc13 Requires: /bin/bash ibus >= 1.2.0 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 Approved -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review