Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551857 --- Comment #5 from Colin Coe <colin.coe@xxxxxxxxx> 2010-02-03 21:08:26 EST --- At the risk of being pedantic, I think the license is wrong in the spec file. http://fedoraproject.org/wiki/Licensing --- GNU General Public License (no version) GPL+ Yes Yes Yes A GPL or LGPL licensed package that lacks any statement of what version that it's licensed under in the source code/program output/accompanying docs is technically licensed under *any* version of the GPL or LGPL, not just the version in whatever COPYING file they include. --- I think the license should be 'GPL+' not 'GPLv2' is the license file lacks a reference to a version. v1.1 of fwsnort has been released, please consider rebasing to this version. Other than these couple of items, your RPM and spec file look pretty good. You look like you've already been sponsored but I'd prefer a second opinion on this RPM and spec to make sure I've not missed anything. CC -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review